Fix WithSpriteBody crashes #16610
Merged
Fix WithSpriteBody crashes #16610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusion809
added a commit
to fusion809/openra-git
that referenced
this pull request
May 29, 2019
fusion809
added a commit
to fusion809/OpenRA
that referenced
this pull request
May 29, 2019
fusion809
added a commit
to fusion809/OpenRA
that referenced
this pull request
May 29, 2019
ghost
approved these changes
May 29, 2019
fusion809
approved these changes
May 29, 2019
There was a problem hiding this comment.
This improvement fixes the bug for me too. I've even created packages/installers for this commit, so that if anyone wants to test it out and are not on a system where they can easily manually build this PR they can still try it out—https://github.com/fusion809/OpenRA/releases/tag/untagged-6efb55fd238d3ab44e8e.
pchote
approved these changes
May 29, 2019
fusion809
added a commit
to fusion809/OpenRA
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by moving references to
DefaultAnimation.CurrentSequenceintoTraitEnabled.Fixes #16609.